New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
httpcaddyfile: Support configuring pki
app names via global options
#4450
Conversation
e2df4ab
to
cd60afb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I like where this is going, but the syntax might need a little work before I feel comfortable merging it. 👍
cd60afb
to
09d3b20
Compare
09d3b20
to
5bc7933
Compare
@tgelite Could you please verify that this meets your needs? |
5bc7933
to
7d8af08
Compare
Apologies, I've been offline. Yes this is addressing what is needed to
define root and intermediate CA names from the Caddyfile. Thank you.
…On Mon, Dec 13, 2021 at 1:12 PM Matt Holt ***@***.***> wrote:
@tgelite <https://github.com/tgelite> Could you please verify that this
meets your needs?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#4450 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AQKW6VJ7NS7POW5KI67LNYDUQZHRLANCNFSM5I5WYHWQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
--
[image: photograph]
Todd Grayson
Investor, Technical Advisor
EES LLC
m: (303) 601-9193
p: (303) 759-3144
e: ***@***.***
2175 S Jasmine St.
Suite 119
www.Elite-Env.com <http://www.elite-env.com/>
[image: facebook icon] <https://www.facebook.com/EliteEnv> [image: linkedin
icon]
<https://www.linkedin.com/company/Elite-Environmental-Solutions-LLC-CO> [image:
instagram icon] <https://www.instagram.com/EliteEnvLLC>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing here stands out as a blocker IMO. Thanks for implementing this! I'm sure quite a few users will appreciate this.
b1893b6
to
1800679
Compare
Fixes #4435
Pretty self explanatory, allows configuring the PKI app name and root/intermediate common names. Works alongside the existing
acme_server
directive andskip_install_trust
options. We could deprecate the top-levelskip_install_trust
in favor of configuring it via the defaultpki
app, but 🤷♂️ I need no reason to do that right now. This works fine.